Skip to content

Stop using Tracer.Instance if we don't need to #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2025
Merged

Stop using Tracer.Instance if we don't need to #7744

merged 2 commits into from
Nov 27, 2025
+28 −25

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Oct 30, 2025 •
edited
Loading

Summary of changes

Updates a couple of places where we're calling Tracer.Instance where we don't need to

Reason for change

In one of my other PRs I accidentally broke something that should only have affected integration tests, but a bunch of unit tests broke. It highlighted where they were using Tracer.Instance and setting the global tracer for tests. In other places, it revealed that code that tests that looked independent of other tests really wasn't...

Calling Tracer.Instance potentially does a lot of work, as it initializes the tracer. It's also hard to follow if we're making static calls out in places we don't need to. So just pass through the settings we want instead.

Implementation details

Instead of calling Tracer.Instance.Settings, use the value of Tracer or TracerSettings that's already available wherever possible. It makes the tests cleaner too.

Test coverage

Same coverage, just a bit cleaner

Other details

Included as part of the config stack, just because I already refactored some of this code, and can't be bothered to faff with merge conflicts:

https://datadoghq.atlassian.net/browse/LANGPLAT-819

@andrewlock andrewlock requested review from a team as code owners October 30, 2025 17:42
@andrewlock andrewlock added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:tests unit tests, integration tests type:reliability area:data-streams-monitoring labels Oct 30, 2025
andrewlock
andrewlock commented Oct 30, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AdoNet/DbScopeFactory.cs
CommandType = typeof(TCommand);

if (TryGetIntegrationDetails(CommandType.FullName, out var integrationId, out var dbTypeName))
if (TryGetIntegrationDetails(Tracer.Instance.Settings.DisabledAdoNetCommandTypes, CommandType.FullName, out var integrationId, out var dbTypeName))
Copy link
Member Author

@andrewlock andrewlock Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is actually kind of annoying. As it's in a static cctor, we can't pass it in anywhere, which means there's one DbScopeFactoryTests test which will use this and end up initializing the global tracer. Oh well.

Copy link
Collaborator

@bouwkast bouwkast Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:sorry: pretty sure this was me

Copy link
Contributor

@zacharycmontoya zacharycmontoya Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I understand that we want to minimize work but I feel like we should calculate all DbCommands regardless of config (i.e. no dependency here) and then we do the config check on the hot path, which allows this setting to be hot-reloadable or "config at runtime" ready

Copy link
Contributor

@zacharycmontoya zacharycmontoya Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concretely, I'm suggesting that we remove the TryGetIntegrationDetails call in the static constructor of Cache<TCommand> and refactor the other call in CreateDbCommandScope a bit. Perhaps in a separate PR

Copy link
Member Author

@andrewlock andrewlock Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see arguments both ways tbh.

The only downside to @zacharycmontoya's proposal would be more work to do for custom DbCommands (ones that we don't explicitly know about), which are also marked as disabled initially, and which customers have marked as disabled. The question I would have is whether that's ok - e.g. if they're disabled because we're erroring out literally running TryGetIntegrationDetails, and that's why they disabled it, then that could be a problem. If it's just an optimization, then yes, it probably is fine.

That said, this actually is technically already hot-reloadable. The DisabledAdoNetCommandTypes setting passed in here is used to decide whether to populate the cache for custom types, but if we don't populate the cache, then we run TryGetIntegrationDetails() and check DisabledAdoNetCommandTypes at runtime anyway. So if this changes, then the result changes, it will just never be cached in that scenario.

So on that basis, I think removing the TryGetIntegrationDetails has a small amount of risk (if customer disabled adonet due to errors - not sure if that's really possible, but I can believe it), means a small bit more work (calculating values which will never be used), and doesn't change how hot-reloadable we are in general (though if we made it hot reloadable, we'd have to rethink how caching works). The plus side is it removes the static access to Tracer.Instance which is better for tests.

So yeah, I'm torn 🤷‍♂️ I'd say separate PR either way, given the questions, as the current behaviour in this PR is identical to the existing. But it's worth thinking about

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
bouwkast
bouwkast approved these changes Oct 30, 2025
View reviewed changes
tracer/src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AdoNet/DbScopeFactory.cs
CommandType = typeof(TCommand);

if (TryGetIntegrationDetails(CommandType.FullName, out var integrationId, out var dbTypeName))
if (TryGetIntegrationDetails(Tracer.Instance.Settings.DisabledAdoNetCommandTypes, CommandType.FullName, out var integrationId, out var dbTypeName))
Copy link
Collaborator

@bouwkast bouwkast Oct 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:sorry: pretty sure this was me

tracer/test/Datadog.Trace.Tests/DataStreamsMonitoring/DataStreamsContextPropagatorTests.cs
[Fact]
public void CanRoundTripPathwayContext()
[Theory]
[CombinatorialData]
Copy link
Collaborator

@bouwkast bouwkast Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 30, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7744) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration74.40 ± (74.47 - 75.23) ms74.06 ± (74.03 - 74.80) ms-0.5%✅
.NET Framework 4.8 - Bailout
duration80.15 ± (80.08 - 80.80) ms80.20 ± (79.74 - 80.50) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1061.68 ± (1061.32 - 1068.47) ms1063.27 ± (1063.57 - 1070.72) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.03 ± (22.94 - 23.11) ms22.92 ± (22.84 - 23.01) ms-0.4%✅
process.time_to_main_ms88.29 ± (87.88 - 88.69) ms87.27 ± (86.94 - 87.61) ms-1.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.91 ± (10.91 - 10.92) MB-0.3%✅
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.82 ± (22.76 - 22.89) ms22.92 ± (22.86 - 22.98) ms+0.4%✅⬆️
process.time_to_main_ms89.38 ± (89.01 - 89.76) ms89.58 ± (89.23 - 89.93) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.98 ± (10.98 - 10.98) MB10.96 ± (10.96 - 10.97) MB-0.1%✅
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms222.87 ± (221.46 - 224.27) ms220.53 ± (219.25 - 221.81) ms-1.0%✅
process.time_to_main_ms503.54 ± (502.44 - 504.64) ms500.51 ± (499.47 - 501.54) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed47.89 ± (47.86 - 47.91) MB47.86 ± (47.84 - 47.88) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms21.76 ± (21.69 - 21.82) ms21.80 ± (21.72 - 21.89) ms+0.2%✅⬆️
process.time_to_main_ms77.03 ± (76.75 - 77.31) ms77.15 ± (76.79 - 77.52) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.63 ± (10.63 - 10.63) MB10.63 ± (10.63 - 10.63) MB+0.0%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.49 ± (21.43 - 21.55) ms21.64 ± (21.58 - 21.70) ms+0.7%✅⬆️
process.time_to_main_ms76.68 ± (76.39 - 76.97) ms77.20 ± (76.89 - 77.51) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.68 ± (10.67 - 10.68) MB10.69 ± (10.68 - 10.69) MB+0.1%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms212.47 ± (211.38 - 213.57) ms210.01 ± (208.79 - 211.23) ms-1.2%✅
process.time_to_main_ms471.73 ± (470.67 - 472.78) ms466.72 ± (465.63 - 467.82) ms-1.1%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.12 ± (48.09 - 48.16) MB48.14 ± (48.12 - 48.16) MB+0.0%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms20.04 ± (19.97 - 20.11) ms20.09 ± (20.02 - 20.16) ms+0.2%✅⬆️
process.time_to_main_ms76.84 ± (76.49 - 77.18) ms76.22 ± (75.91 - 76.53) ms-0.8%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.70 ± (7.70 - 7.71) MB7.67 ± (7.67 - 7.68) MB-0.4%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.81 ± (19.75 - 19.86) ms19.90 ± (19.83 - 19.96) ms+0.5%✅⬆️
process.time_to_main_ms76.57 ± (76.29 - 76.85) ms76.29 ± (75.99 - 76.59) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.74 ± (7.74 - 7.75) MB7.71 ± (7.71 - 7.72) MB-0.4%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms194.84 ± (193.71 - 195.97) ms194.08 ± (193.12 - 195.04) ms-0.4%✅
process.time_to_main_ms458.46 ± (457.43 - 459.49) ms456.68 ± (455.49 - 457.88) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.51 ± (36.47 - 36.55) MB36.40 ± (36.36 - 36.44) MB-0.3%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.1%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.54 ± (193.58 - 194.38) ms192.60 ± (192.50 - 193.37) ms-0.5%✅
.NET Framework 4.8 - Bailout
duration196.79 ± (196.70 - 197.15) ms196.38 ± (196.20 - 196.75) ms-0.2%✅
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1111.46 ± (1117.39 - 1126.64) ms1110.30 ± (1112.40 - 1120.47) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms188.34 ± (188.01 - 188.67) ms188.12 ± (187.69 - 188.54) ms-0.1%✅
process.time_to_main_ms80.62 ± (80.45 - 80.80) ms80.70 ± (80.45 - 80.95) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.12 ± (16.09 - 16.15) MB16.09 ± (16.07 - 16.12) MB-0.2%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)+0.0%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.18 ± (186.88 - 187.47) ms188.61 ± (188.13 - 189.09) ms+0.8%✅⬆️
process.time_to_main_ms82.02 ± (81.90 - 82.13) ms82.48 ± (82.28 - 82.68) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.18 ± (16.15 - 16.21) MB16.14 ± (16.10 - 16.17) MB-0.3%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)+0.0%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms393.98 ± (391.82 - 396.14) ms405.62 ± (402.58 - 408.65) ms+3.0%✅⬆️
process.time_to_main_ms474.57 ± (474.01 - 475.13) ms472.34 ± (471.68 - 473.00) ms-0.5%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.54 ± (58.40 - 58.69) MB58.73 ± (58.60 - 58.86) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 30)29 ± (29 - 29)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms194.02 ± (193.57 - 194.46) ms192.04 ± (191.76 - 192.32) ms-1.0%✅
process.time_to_main_ms70.57 ± (70.38 - 70.77) ms69.80 ± (69.67 - 69.94) ms-1.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.39 ± (16.35 - 16.42) MB16.23 ± (16.11 - 16.34) MB-1.0%✅
runtime.dotnet.threads.count19 ± (19 - 19)18 ± (18 - 19)-3.8%✅
.NET 6 - Bailout
process.internal_duration_ms192.34 ± (192.07 - 192.60) ms191.33 ± (191.06 - 191.59) ms-0.5%✅
process.time_to_main_ms71.07 ± (70.99 - 71.15) ms70.93 ± (70.83 - 71.02) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.44 ± (16.37 - 16.51) MB16.13 ± (15.98 - 16.28) MB-1.9%✅
runtime.dotnet.threads.count20 ± (20 - 20)19 ± (19 - 19)-4.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms407.44 ± (405.36 - 409.53) ms406.57 ± (404.46 - 408.68) ms-0.2%✅
process.time_to_main_ms442.60 ± (442.01 - 443.20) ms441.60 ± (441.06 - 442.14) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed58.86 ± (58.72 - 59.01) MB58.90 ± (58.75 - 59.04) MB+0.1%✅⬆️
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (29 - 30)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms190.88 ± (190.49 - 191.26) ms189.99 ± (189.69 - 190.30) ms-0.5%✅
process.time_to_main_ms69.70 ± (69.52 - 69.89) ms69.56 ± (69.35 - 69.77) ms-0.2%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.70 - 11.75) MB11.77 ± (11.74 - 11.81) MB+0.4%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.5%✅
.NET 8 - Bailout
process.internal_duration_ms189.60 ± (189.39 - 189.80) ms190.16 ± (189.85 - 190.46) ms+0.3%✅⬆️
process.time_to_main_ms70.29 ± (70.20 - 70.37) ms70.31 ± (70.21 - 70.42) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.85) MB11.80 ± (11.77 - 11.84) MB-0.1%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.7%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms367.25 ± (365.83 - 368.66) ms363.04 ± (361.33 - 364.74) ms-1.1%✅
process.time_to_main_ms430.23 ± (429.64 - 430.81) ms427.53 ± (426.86 - 428.19) ms-0.6%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.95 ± (47.92 - 47.98) MB47.81 ± (47.77 - 47.85) MB-0.3%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (74ms)  : 69, 80
    master - mean (75ms)  : 69, 81

    section Bailout
    This PR (7744) - mean (80ms)  : 74, 86
    master - mean (80ms)  : 75, 86

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (1,067ms)  : 1016, 1118
    master - mean (1,065ms)  : 1013, 1117
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (118ms)  : 110, 125
    master - mean (119ms)  : 111, 127

    section Bailout
    This PR (7744) - mean (120ms)  : 113, 127
    master - mean (120ms)  : 113, 127

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (762ms)  : 729, 796
    master - mean (765ms)  : 733, 797
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (106ms)  : 99, 113
    master - mean (106ms)  : 101, 112

    section Bailout
    This PR (7744) - mean (106ms)  : 99, 113
    master - mean (105ms)  : 100, 111

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (708ms)  : 680, 735
    master - mean (722ms)  : 688, 755
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (105ms)  : 99, 111
    master - mean (106ms)  : 99, 112

    section Bailout
    This PR (7744) - mean (105ms)  : 98, 112
    master - mean (105ms)  : 100, 110

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (689ms)  : 662, 717
    master - mean (696ms)  : 666, 725
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (193ms)  : 189, 197
    master - mean (194ms)  : 190, 198

    section Bailout
    This PR (7744) - mean (196ms)  : 194, 199
    master - mean (197ms)  : 195, 199

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (1,116ms)  : 1058, 1175
    master - mean (1,122ms)  : 1051, 1193
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (277ms)  : 273, 282
    master - mean (277ms)  : 273, 282

    section Bailout
    This PR (7744) - mean (280ms)  : 273, 286
    master - mean (277ms)  : 273, 282

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (911ms)  : 851, 971
    master - mean (909ms)  : 866, 952
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (270ms)  : 266, 274
    master - mean (273ms)  : 266, 279

    section Bailout
    This PR (7744) - mean (270ms)  : 267, 274
    master - mean (271ms)  : 268, 274

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (880ms)  : 845, 915
    master - mean (884ms)  : 841, 926
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7744) - mean (269ms)  : 265, 274
    master - mean (270ms)  : 263, 277

    section Bailout
    This PR (7744) - mean (270ms)  : 267, 273
    master - mean (269ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (7744) - mean (823ms)  : 805, 841
    master - mean (829ms)  : 808, 849
Loading

@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 8a3aee6 to 753da8d Compare October 31, 2025 18:04
@andrewlock andrewlock requested review from a team as code owners October 31, 2025 18:04
@andrewlock andrewlock requested review from anna-git and removed request for a team October 31, 2025 18:04
@andrewlock andrewlock force-pushed the andrew/settings/5-remove-mutablesettings branch from 1b1f494 to f94e51b Compare October 31, 2025 18:04
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 753da8d to 3a96423 Compare November 3, 2025 17:30
@andrewlock andrewlock force-pushed the andrew/settings/5-remove-mutablesettings branch from f94e51b to 75937f5 Compare November 3, 2025 17:30
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 3a96423 to f01f8c6 Compare November 4, 2025 09:26
@andrewlock andrewlock force-pushed the andrew/settings/5-remove-mutablesettings branch from 75937f5 to 8111379 Compare November 4, 2025 09:26
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from f01f8c6 to 4fd8303 Compare November 4, 2025 10:30
@andrewlock andrewlock force-pushed the andrew/settings/5-remove-mutablesettings branch from 8111379 to 177c2a0 Compare November 4, 2025 10:30
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 10ce7a6 to 47ddbf9 Compare November 11, 2025 10:04
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from 2fbbd7f to c677778 Compare November 11, 2025 10:04
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 47ddbf9 to 62b1d54 Compare November 11, 2025 18:13
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from c677778 to 1ad1119 Compare November 11, 2025 18:13
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 62b1d54 to 854cac9 Compare November 12, 2025 12:04
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from 1ad1119 to d33ef91 Compare November 12, 2025 12:04
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 854cac9 to 7763c79 Compare November 12, 2025 12:22
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from d33ef91 to 9d94c38 Compare November 12, 2025 12:22
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 7763c79 to 71c8119 Compare November 12, 2025 13:41
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from 9d94c38 to a34b7b5 Compare November 12, 2025 13:41
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 71c8119 to aad788e Compare November 14, 2025 07:41
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from a34b7b5 to fe19d1a Compare November 14, 2025 07:41
@anna-git anna-git removed their request for review November 18, 2025 12:27
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from aad788e to bf267a8 Compare November 25, 2025 16:46
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from fe19d1a to b8b2b59 Compare November 25, 2025 16:46
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from bf267a8 to 451e24d Compare November 26, 2025 08:17
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from b8b2b59 to 9ceef6e Compare November 26, 2025 08:17
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 451e24d to dca9144 Compare November 26, 2025 11:09
@andrewlock andrewlock force-pushed the andrew/settings/6-fix-telemetry-reporting branch from 9ceef6e to c043b52 Compare November 26, 2025 11:09
Base automatically changed from andrew/settings/6-fix-telemetry-reporting to andrew/settings/5-remove-mutablesettings November 26, 2025 11:10
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch 2 times, most recently from efe95e4 to 0e2c7d3 Compare November 26, 2025 13:34
@andrewlock andrewlock force-pushed the andrew/settings/5-remove-mutablesettings branch from 447027a to 9db67e4 Compare November 26, 2025 13:34
Base automatically changed from andrew/settings/5-remove-mutablesettings to master November 26, 2025 18:21
@andrewlock andrewlock force-pushed the andrew/settings/6a-stop-using-tracer-instance branch from 0e2c7d3 to 18206ad Compare November 27, 2025 07:55
@andrewlock andrewlock merged commit 85673e7 into master Nov 27, 2025
151 checks passed
@andrewlock andrewlock deleted the andrew/settings/6a-stop-using-tracer-instance branch November 27, 2025 09:39
@github-actions github-actions bot added this to the vNext-v3 milestone Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwkast bouwkast bouwkast approved these changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

No one assigned

Labels

area:data-streams-monitoring area:tests unit tests, integration tests area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:reliability

Projects

None yet

Milestone

vNext-v3

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlock @bouwkast @zacharycmontoya